model_split: Fixed #19236 - fixed error for abstract models with a split method #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except AttributeError: | ||
| # If it doesn't have a split it's actually a model class | ||
|
|
||
| if isinstance(relation, basestring): |
There was a problem hiding this comment.
basestring isn't correct on python3, you want to use django.utils.six.string_types
|
Besides that one comment this is good to go! |
alex
added a commit
that referenced
this pull request
Nov 4, 2012
model_split: Fixed #19236 - fixed error for abstract models with a split method
alex
added a commit
that referenced
this pull request
Nov 4, 2012
model_split: Fixed #19236 - fixed error for abstract models with a split method Backport of 8d3f932
kmtracey
added a commit
that referenced
this pull request
Dec 21, 2015
…ets. This includes the ability to collapse inlines by specifying a class named 'collapse'.
timgraham
added a commit
to timgraham/django
that referenced
this pull request
Jan 11, 2016
timgraham
added a commit
to timgraham/django
that referenced
this pull request
Jan 11, 2016
lwiecek
pushed a commit
to lwiecek/django
that referenced
this pull request
Apr 14, 2016
…fieldsets. This includes the ability to collapse inlines by specifying a class named 'collapse'.
lwiecek
pushed a commit
to lwiecek/django
that referenced
this pull request
Apr 14, 2016
olivierdalang
pushed a commit
to olivierdalang/django
that referenced
this pull request
Aug 10, 2016
Fixed django#494 -- Added ability to specify classes on admin inline fieldsets. Conflicts: docs/releases/1.11.txt
olivierdalang
pushed a commit
to olivierdalang/django
that referenced
this pull request
Dec 14, 2016
Fixed django#494 -- Added ability to specify classes on admin inline fieldsets. Conflicts: docs/releases/1.11.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket:
https://code.djangoproject.com/ticket/19236